style: adjust page indicator dot size in fullscreen mode#751
Merged
Conversation
Changed the implicit width and height of page indicator dots from 10 to 8 pixels when not in windowed mode (i.e., in fullscreen mode). This reduces the visual size of the navigation dots slightly to create a more balanced and less intrusive appearance during fullscreen folder browsing. The adjustment maintains the windowed mode size at 5 pixels while optimizing the fullscreen experience with slightly smaller dots that are still clearly visible but less dominant in the UI. Log: Adjusted page indicator dot size in fullscreen folder view for better visual balance Influence: 1. Test folder navigation in both windowed and fullscreen modes 2. Verify page indicator dots are visible and correctly sized in each mode 3. Check that the current page indicator remains clearly distinguishable 4. Ensure touch/click targets remain accessible 5. Verify visual consistency across different screen resolutions 6. Test with various folder content and page counts style: 调整全屏模式下的页面指示点大小 将非窗口模式（即全屏模式）下的页面指示点的隐式宽度和高度从10像素调整为8 像素。这略微减小了导航点的视觉尺寸，在全屏文件夹浏览时创建更平衡且不那么 突兀的外观。 此调整保持窗口模式下的尺寸为5像素，同时通过略微减小但仍清晰可见的指示点 来优化全屏体验，使其在UI中不那么显眼。 Log: 调整全屏文件夹视图中的页面指示点大小以获得更好的视觉平衡 Influence: 1. 测试窗口模式和全屏模式下的文件夹导航 2. 验证页面指示点在每种模式下是否可见且尺寸正确 3. 检查当前页面指示器是否保持清晰可辨 4. 确保触摸/点击目标保持可访问性 5. 验证不同屏幕分辨率下的视觉一致性 6. 测试各种文件夹内容和页面数量 PMS: BUG-356945
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the size of page indicator dots in fullscreen (non-windowed) mode within FolderGridViewPopup to make them slightly smaller while keeping windowed mode unchanged. Flow diagram for page indicator dot sizing by modeflowchart TD
A[FolderGridViewPopup] --> B{isWindowedMode}
B -- true --> C[Dot size
implicitWidth 5
implicitHeight 5]
B -- false --> D[Dot size
implicitWidth 8
implicitHeight 8]
A --> E[Dot spacing
isWindowedMode true: 5
isWindowedMode false: 10]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the page indicator dot size (and possibly spacing) into named properties or constants so the windowed/fullscreen sizes stay in sync and are easier to tweak in one place later.
- Given that the spacing remains 10 while fullscreen dot size is reduced to 8, double-check whether the visual layout still looks balanced or whether spacing should scale with the dot size as well.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the page indicator dot size (and possibly spacing) into named properties or constants so the windowed/fullscreen sizes stay in sync and are easier to tweak in one place later.
- Given that the spacing remains 10 while fullscreen dot size is reduced to 8, double-check whether the visual layout still looks balanced or whether spacing should scale with the dot size as well.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review这段代码是一个 QML (Qt Modeling Language) 文件的差异片段，主要修改了 以下是对这段代码的详细审查和改进意见： 1. 语法逻辑审查
2. 代码质量审查
3. 代码性能审查
4. 代码安全审查
5. 综合改进建议代码示例结合上述建议，改进后的代码可能如下： Popup {
// 假设这些定义在组件的根层级或样式配置中
readonly property int indicatorSizeWindowed: 5
readonly property int indicatorSizeFullscreen: 8
readonly property color indicatorColor: "white" // 或者使用 Qt.rgba(1, 1, 1, 1)
// ... 其他代码 ...
delegate: Rectangle {
// 使用定义好的属性，提高可维护性
implicitWidth: isWindowedMode ? indicatorSizeWindowed : indicatorSizeFullscreen
implicitHeight: isWindowedMode ? indicatorSizeWindowed : indicatorSizeFullscreen
// 安全的半径计算
radius: width > 0 ? width / 2 : 0
// 使用预定义颜色，并优化透明度逻辑的可读性
color: {
if (index === folderPageIndicator.currentIndex)
return Qt.rgba(indicatorColor.r, indicatorColor.g, indicatorColor.b, 0.9);
if (pressed)
return Qt.rgba(indicatorColor.r, indicatorColor.g, indicatorColor.b, 0.5);
return Qt.rgba(indicatorColor.r, indicatorColor.g, indicatorColor.b, 0.2);
}
}
}总结： |
Ivy233
approved these changes
Apr 21, 2026
BLumia
approved these changes
Apr 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, Ivy233, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the implicit width and height of page indicator dots from 10 to 8 pixels when not in windowed mode (i.e., in fullscreen mode). This reduces the visual size of the navigation dots slightly to create a more balanced and less intrusive appearance during fullscreen folder browsing.
The adjustment maintains the windowed mode size at 5 pixels while optimizing the fullscreen experience with slightly smaller dots that are still clearly visible but less dominant in the UI.
Log: Adjusted page indicator dot size in fullscreen folder view for better visual balance
Influence:
style: 调整全屏模式下的页面指示点大小
将非窗口模式（即全屏模式）下的页面指示点的隐式宽度和高度从10像素调整为8
像素。这略微减小了导航点的视觉尺寸，在全屏文件夹浏览时创建更平衡且不那么
突兀的外观。
此调整保持窗口模式下的尺寸为5像素，同时通过略微减小但仍清晰可见的指示点
来优化全屏体验，使其在UI中不那么显眼。
Log: 调整全屏文件夹视图中的页面指示点大小以获得更好的视觉平衡
Influence:
PMS: BUG-356945
Summary by Sourcery
Enhancements: